Repository navigation
ci(pack): enable PackageValidation with per-package baselines (#175) - #190
Merged
Merged
Conversation
Adds the fleet-standard PackageValidation gate to both shipped csprojs so `dotnet pack` runs Microsoft.DotNet.ApiCompat against the last-published NuGet version. Accidental ABI breaks — removed / renamed / type-changed public members, dropped TFMs — fail pack instead of shipping. Baselines (per current NuGet state): Wolfgang.Extensions.Logging.Data → 0.3.0 Wolfgang.Extensions.Logging.Data.EntityFramework6 → 0.2.0 EF6 lags the main package's cadence (last release was 0.2.0 while Data is at 0.3.0), so the two csprojs pin different baselines. Each will bump independently after its next release. Local `dotnet pack -c Release -v:normal` on both projects reports `RunPackageValidation: APICompat ran successfully without finding any breaking changes` — no ABI breaks between the current main and either published baseline, so this lands cleanly. Multi-line comment in each csproj explains the mechanism, the maintenance step (baseline bump after every release per the per-repo release flow), and the release.yaml pack-and-validate exercise path. Closes #175. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the fleet-standard
PackageValidationgate to both shipped csprojs sodotnet packruns Microsoft.DotNet.ApiCompat against the last-published NuGet version. Accidental ABI breaks — removed / renamed / type-changed public members, dropped TFMs — fail pack instead of shipping.Fleet precedent: Try-Pattern Chris-Wolfgang/Try-Pattern#319 (same pattern, same rationale comment).
Closes #175.
Baselines (per current NuGet state)
Wolfgang.Extensions.Logging.DataWolfgang.Extensions.Logging.Data.EntityFramework6EF6 lags the main package's cadence (last EF6 release was 0.2.0 while Data is at 0.3.0), so the two csprojs pin different baselines. Each will bump independently after its next release, tracked by the maintenance-step comment.
Local validation
dotnet pack -c Release -v:normalon both projects:No ABI breaks between current main and either baseline — no code changes needed for this to land.
Maintenance step this institutes
Every future release should bump
<PackageValidationBaselineVersion>to whatever version just shipped, as a post-deploy PR — perfeedback_post_deploy_baseline_bumpandreference_packagevalidation_baseline_timing. Comment in each csproj records this so a future maintainer sees it without hunting.Test plan
dotnet pack -c Release -v:normalon both csprojs — validation ran, zero breaksReproducible Buildjob packs and should also succeedrelease.yaml(when the next release cuts) exercises the gate at release time — nothing to test here until thenNotes for the maintainer
🤖 Generated with Claude Code